Fix/installation #28
Merged
Fix/installation #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarusified
reviewed
Oct 14, 2020
jarusified
reviewed
Oct 14, 2020
setup.py
Outdated
| def list_files(directory): | ||
| paths = [] | ||
| for (path, directories, filenames) in os.walk(directory): | ||
| files = [os.path.join(path, f) for f in filenames] |
Collaborator
There was a problem hiding this comment.
variable files is not being used by the function, can we remove it?
Collaborator
There was a problem hiding this comment.
I think we need to copy only the data, and not the .callflow files. I think we can add a statement to check the type of files that can be considered as well. Otherwise, it might copy a lot of files.
Contributor
Author
There was a problem hiding this comment.
yes, looks like a copy-paste issue. get rid of files.
Yes, to .callflow too. we should see if os.walk returns hidden files/directories. i didnt encounter this.
jarusified
reviewed
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to installation. Tested with
python setup.py installandspack install. Still need to update the readme.